feat(deploy): Scale down orca & rosco during deploys #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
commented
Jul 7, 2017
|
|
||
| allOrcas = allOrcas.subList(0, orcaCount - MAX_REMAINING_SERVER_GROUPS); | ||
| for (Integer orcaVersion : allOrcas) { | ||
| // TODO(lwander) consult clouddriver to ensure this orca isn't enabled |
There was a problem hiding this comment.
TODO was dropped because the orca versions outside of MAX_REMAINING_SERVER_GROUPS cannot be enabled, since the rollback operation requested by halyard ensures the highest sequence number is always the only one serving traffic.
jtk54
approved these changes
Jul 7, 2017
| List<Integer> runningVersions) { | ||
| int runningVersionCount = runningVersions.size(); | ||
|
|
||
| if (runningVersionCount <= 1) { |
There was a problem hiding this comment.
This is not the usual case, correct? Maybe add logging here so you avoid possibly silently failing.
There was a problem hiding this comment.
This happens on every fresh deploy - you'll only have one of each service. I'll add a log statement but it's expected to be hit
There was a problem hiding this comment.
Got it, still maybe worth it.
When possible, orca & rosco will be scaled down during deployments (if they aren't handling any work).
lwander
force-pushed
the
scale-down-orca-rosco
branch
from
e7f046b
to
9fffc59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When possible, orca & rosco will be scaled down during deployments (if they aren't handling any work).