-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deploy): Scale down orca & rosco during deploys #593
Conversation
|
||
allOrcas = allOrcas.subList(0, orcaCount - MAX_REMAINING_SERVER_GROUPS); | ||
for (Integer orcaVersion : allOrcas) { | ||
// TODO(lwander) consult clouddriver to ensure this orca isn't enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO was dropped because the orca versions outside of MAX_REMAINING_SERVER_GROUPS cannot be enabled, since the rollback operation requested by halyard ensures the highest sequence number is always the only one serving traffic.
List<Integer> runningVersions) { | ||
int runningVersionCount = runningVersions.size(); | ||
|
||
if (runningVersionCount <= 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the usual case, correct? Maybe add logging here so you avoid possibly silently failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens on every fresh deploy - you'll only have one of each service. I'll add a log statement but it's expected to be hit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, still maybe worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed & logged
When possible, orca & rosco will be scaled down during deployments (if they aren't handling any work).
e7f046b
to
9fffc59
Compare
When possible, orca & rosco will be scaled down during deployments (if they aren't handling any work).